#1806: "make smoke" does not respect TEST_JOBS
----------------------+-----------------------------------------------------
Reporter: dukeleto | Owner:
Type: bug | Status: new
Priority: normal | Milestone:
Component: testing | Version: 2.8.0
Severity: medium | Keywords:
Lang: | Patch:
Platform: all |
----------------------+-----------------------------------------------------
Comment(by mikehh):
Hi,
make smoke/smolder_test does not seem to handle TEST_JOBS at all
from the makefile:
{{{
# Normal test package
test : test_core
# Test Parrot core.
test_core: test_prep
$(PERL) t/harness $(EXTRA_TEST_ARGS)
# run the test suite, create a TAP archive and send it off to smolder
smolder_test : test_prep
$(PERL) t/harness $(EXTRA_TEST_ARGS) --archive --send-to-smolder
...
smoke : smolder_test
}}}
if you look at t/harness we have the following lines:
{{{
my $harness;
if ($longopts->{archive}) {
eval { require TAP::Harness::Archive };
...
$harness = TAP::Harness::Archive->new(
{
verbosity => $ENV{HARNESS_VERBOSE},
archive => 'parrot_test_run.tar.gz',
merge => 1,
extra_properties => \%env_data,
extra_files => [ 'myconfig', 'config_lib.pir' ],
}
);
$harness->runtests(@tests);
send_archive_to_smolder(%env_data) if $longopts->{send_to_smolder};
}
...
else {
eval { require TAP::Harness };
if ($@) {
Test::Harness::runtests(@tests);
exit;
}
else {
$harness = TAP::Harness->new({
verbosity => $ENV{HARNESS_VERBOSE},
merge => 0,
jobs => $ENV{TEST_JOBS} || 1,
directives => 1,
});
}
my $results = $harness->runtests(@tests);
exit ( $results->all_passed() ? 0 : 1 );
}
}}}
please note that $harness is different in for example make test vs make
smoke - make test uses TAP::Harness while make smoke uses
TAP::Harness::Archive
I haven't looked further but I suspect that TAP::Harness::Archive expects
the output to be sequential, so does not accept TEST_JOBS
Cheers, Michael (mikehh)
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1806#comment:1>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
