#883: Use the right PTR2INTVAL() macro, not (INTVAL) for type conversion
-------------------+--------------------------------------------------------
Reporter: jimmy | Type: cage
Status: new | Priority: normal
Milestone: | Component: core
Version: 1.4.0 | Severity: medium
Keywords: | Lang:
Patch: | Platform:
-------------------+--------------------------------------------------------
Comment(by cotto):
Thanks, bacek. This is indeed something we need to fix.
{{{ack -a '\(\s*INTVAL\s*\)'|wc -l}}} currently returns 241 after make
realclean and isn't guaranteed to be exhaustive in catching misuses. This
raises two questions. The first is how we know when to close this ticket.
There are legitimate uses for INTVAL casts and we want to make sure that
those don't prevent this ticket from being closed. A manual review is
probably the best option. The second issue is making sure that this
problem doesn't appear again. Unless someone wants to write a codingstd
test that parses C well enough to detect this, vigilance is the best way
to keep it out.
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/883#comment:8>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
