#1919: Removal of dead functions in src/packfile/api.c
--------------------+-------------------------------------------------------
Reporter: rfw | Type: deprecation
Status: new | Priority: normal
Milestone: | Component: none
Version: 2.10.0 | Severity: medium
Keywords: | Lang:
Patch: | Platform:
--------------------+-------------------------------------------------------
Comment(by rfw):
Okay, I lied. Here's a better analysis of it.
No references exist to `Parrot_switch_to_cs_by_nr` and
`PackFile_remove_segment_by_name` in the code anywhere, and can be safely
removed.
`PackFile_Annotations_dump` is not being called anywhere, but it has the
potential to be called, other dumping functions are covered. It is
possible that `packdump` does not support dumping of annotations and
therefore this is never called.
With `PackFile_Segment_new`, no functions ever create a packfile with the
type `PF_UNKNOWN_SEG`. However, function will be called with faulty
packfile data and most likely should not be removed as it zeroes out that
portion.
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1919#comment:1>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
