#1988: lib/Parrot/Pmc2c/PMCEmitter.pm: make file match package.
---------------------+------------------------------------------------------
Reporter: jkeenan | Owner: jkeenan
Type: bug | Status: assigned
Priority: normal | Milestone:
Component: build | Version: 3.0.0
Severity: medium | Keywords:
Lang: | Patch: new
Platform: all |
---------------------+------------------------------------------------------
Changes (by jkeenan):
* cc: tewk, mikehh (added)
* platform: => all
* component: configure => build
* patch: => new
Comment:
Much to my surprise, I was able to pick up all the methods in the
PMCEmitter.pm's version of Parrot::Pmc2c::PMC, plunk them down in
''lib/Parrot/Pmc2c/PMC.pm'' and have everything just work! So I was able
to eliminate one 1100+-lines-of-code file, albeit by moving the code
elsewhere.
I was further surprised to learn that two entire packages,
''lib/Parrot/Pmc2c/PMC/ParrotClass.pm'' and
''lib/Parrot/Pmc2c/ComposedMethod.pm'', were '''never''' used in the
Parrot build process. We've been carrying these two files in our
distribution for four years for no evident purpose at all. Two more files
removed.
I have attached a patch showing the current differences between master and
the ''tt1988_pmcemitter'' branch; please review.
I will be working on additional cleanup of code underneath the
Parrot::Pmc2c::* hierarchy, but we should consider whether we want to try
to merge this branch into master before or after the 3.1 release on
February 15.
Thank you very much.
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1988#comment:7>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
