#1999: Parrot_PMC_get_pmc : Does it work correctly?
--------------------------+-------------------------------------------------
Reporter: dukeleto | Owner: dukeleto
Type: bug | Status: assigned
Priority: normal | Milestone:
Component: embed/extend | Version: 3.0.0
Severity: medium | Keywords:
Lang: | Patch:
Platform: all |
--------------------------+-------------------------------------------------
Changes (by dukeleto):
* owner: => dukeleto
* status: new => assigned
* component: none => embed/extend
Old description:
> I added the following test here
>
> https://github.com/parrot/parrot/commit/ac2ad789fc094d33a9db1f984e85ed100047be49
>
> {{{
>
> # TODO: Is this test correct?
> extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_get_pmc");
> Parrot_PMC_set_integer_native(interp, pmc, 42);
> Parrot_PMC_push_pmc(interp, rpa, pmc);
> Parrot_PMC_push_pmc(interp, rpa, pmc);
> Parrot_PMC_push_pmc(interp, rpa, pmc);
>
> pmc3 = Parrot_PMC_get_iter(interp, rpa);
> pmc2 = Parrot_PMC_get_pmc(interp, pmc3);
> Parrot_printf(interp,"%P\n", pmc2);
> CODE
> 3
> Done!
> OUTPUT
>
> }}}
>
> It currently passed, but is it correct? i.e. If get_pmc is called on a
> RPA iterator, should it return the number of elements in the RPA?
New description:
I added the following test here
https://github.com/parrot/parrot/commit/ac2ad789fc094d33a9db1f984e85ed100047be49
{{{
# TODO: Is this test correct?
extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_get_pmc");
Parrot_PMC_set_integer_native(interp, pmc, 42);
Parrot_PMC_push_pmc(interp, rpa, pmc);
Parrot_PMC_push_pmc(interp, rpa, pmc);
Parrot_PMC_push_pmc(interp, rpa, pmc);
pmc3 = Parrot_PMC_get_iter(interp, rpa);
pmc2 = Parrot_PMC_get_pmc(interp, pmc3);
Parrot_printf(interp,"%P\n", pmc2);
CODE
3
Done!
OUTPUT
}}}
It currently passes, but is it correct? i.e. If get_pmc is called on a RPA
iterator, should it return the number of elements in the RPA?
--
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1999#comment:1>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
