#2118: t/src/checkdepend.t fails when extra nci tthunks are disabled
----------------------+-----------------------------------------------------
Reporter: dukeleto | Owner: jkeenan
Type: bug | Status: assigned
Priority: normal | Milestone:
Component: testing | Version: 3.4.0
Severity: medium | Keywords:
Lang: | Patch: applied
Platform: all |
----------------------+-----------------------------------------------------
Changes (by jkeenan):
* owner: plobsing => jkeenan
* status: new => assigned
* patch: new => applied
Comment:
Replying to [comment:3 ligne]:
> i just saw (almost) the same thing happen when built --without-core-nci-
thunks:
Taking into account this report from ligne++ and his suggestion in TT
#2116, I have applied this patch in commit 9f6220f:
{{{
diff --git a/t/library/pcre.t b/t/library/pcre.t
index 928bd0b..388ec55 100644
--- a/t/library/pcre.t
+++ b/t/library/pcre.t
@@ -7,6 +7,7 @@ use lib qw( t . lib ../lib ../../lib );
use Test::More;
use Parrot::Test tests => 2;
+use Parrot::Config qw( %PConfig );
=head1 NAME
@@ -41,8 +42,12 @@ if ($has_pcre && ($^O !~ /MSWin32/)) {
}
SKIP: {
- skip( 'no pcre-config', Test::Builder->new()->expected_tests() )
- unless $has_pcre;
+ skip( 'no pcre-config',
+ Test::Builder->new()->expected_tests()
+ ) unless $has_pcre;
+ skip( 'Parrot built without libffi or extra NCI thunks',
+ Test::Builder->new()->expected_tests()
+ ) unless ($PConfig{HAS_EXTRA_NCI_THUNKS} || $PConfig{HAS_LIBFFI});
## 1
## Check that the library can be loaded and initialized,
diff --git a/t/src/checkdepend.t b/t/src/checkdepend.t
index d7b2f10..d0b9798 100644
--- a/t/src/checkdepend.t
+++ b/t/src/checkdepend.t
@@ -10,6 +10,8 @@ use Fatal qw(open);
use File::Find;
use File::Spec;
use Test::More;
+use lib qw( lib );
+use Parrot::Config;
=head1 NAME
@@ -57,6 +59,10 @@ our %deps;
foreach my $file (sort grep /\.[hc]$/, @incfiles) {
# skip pmcs - we don't handle inheritance correctly
next if $file =~ m{^src/(?:dyn)?pmc/};
+ next if ($file eq 'src/nci/core_thunks.c' and
+ ! defined
$Parrot::Config::PConfig_Temp{PARROT_HAS_CORE_NCI_THUNKS});
+ next if ($file eq 'src/nci/extra_thunks.c' and
+ ! defined
$Parrot::Config::PConfig_Temp{PARROT_HAS_EXTRA_NCI_THUNKS});
open my $fh, '<', $file;
my $guts;
}}}
I have achieved `PASS` on `make test` on linux/i386 with both:
{{{
perl Configure.pl
# and
perl Configure.pl --without-gettext \
--without-gmp \
--without-libffi \
--without-core-nci-thunks \
--without-extra-nci-thunks \
--without-opengl \
--without-readline \
--without-pcre \
--without-zlib \
--without-threads \
--without-icu \
$@
}}}
Will report results from darwin/ppc tomorrow; other tests would be
appreciated.
Thank you very much.
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/2118#comment:4>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
