On Mon, Jul 15, 2019 at 12:26:33PM +0200, Max Staudt wrote: > Currently, the affs code in libparted prints a debug line to stdout when > an Amiga FFS partition is probed. This confuses tools that parse stdout. > > A prominent example is the partitioner (partman) in Debian's installer, > which parses stdout from a tool (parted_devices) that uses libparted to > scan the system's block devices. As of now, Debian cannot be installed > on a typical Amiga: > > https://lists.debian.org/debian-68k/2019/07/msg00015.html > > This patch removes this unexpected printf(). > > Cc: [email protected] > Signed-off-by: Max Staudt <[email protected]> > --- > libparted/fs/amiga/affs.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libparted/fs/amiga/affs.c b/libparted/fs/amiga/affs.c > index c09e8cc..2fa4084 100644 > --- a/libparted/fs/amiga/affs.c > +++ b/libparted/fs/amiga/affs.c > @@ -91,8 +91,6 @@ _generic_affs_probe (PedGeometry* geom, uint32_t kind) > len = geom->length / blocksize - reserved; > pos = (len - 1) / 2; > root = geom->start + (pos + reserved) * blocksize; > - printf ("Pralloc = %d, Reserved = %d, blocksize = %d, root block at > %llu\n", > - prealloc, reserved, blocksize, root); > > if (!ped_device_read (geom->dev, block, root, blocksize)) { > ped_exception_throw(PED_EXCEPTION_ERROR, PED_EXCEPTION_CANCEL, > -- > 2.11.0 > >
Whoops, ack! Thanks for the patch. -- Brian C. Lane (PST8PDT) - weldr.io - lorax - parted
