Hi Brian, Thank you for your efforts to maintain Parted. Your work is appreciated.
And thanks for the link to the git repo. It made testing much easier. My testing with this patch set went well. All tests I performed were successful. More specifically, I have confirmed that file system resizing works correctly with the parted GCC10 Warning Cleanup patch set for: - FAT32 - HFS+ Basically my resize test steps are: - Create and fill 512 MiB partition with 5 files - Remove first 3 files to free up space at start of partition - Get MD5SUMs - Shrink partition to 300 MiB to force moving last 2 files - Compare MD5SUMs to ensure files unchanged If you require further testing then let me know. Regards, Curtis Following is the steps I used on Ubuntu 20.10 for FAT32 testing (and similarly for HFS+). FAT32 TEST STEPS ================ # # - Create MSDOS partition table in GParted # # - Create 512 MiB FAT32 partition in GParted # # - Show partition table # $ sudo parted /dev/sdb unit s print [sudo] password for user: Model: VMware, VMware Virtual S (scsi) Disk /dev/sdb: 4194304s Sector size (logical/physical): 512B/512B Partition Table: msdos Disk Flags: Number Start End Size Type File system Flags 1 2048s 1050623s 1048576s primary fat32 # # - Mount partition, create five 100MiB files, and show disk free. # $ sudo mount /dev/sdb1 /mnt $ for k in 1 2 3 4 5; do sudo dd if=/dev/random of=/mnt/f$k.dat bs=10m count=10; done <snip> $ df /mnt Filesystem 1K-blocks Used Available Use% Mounted on /dev/sdb1 523248 512004 11244 98% /mnt # # - Remove 3 files, show MD5SUM for last files, and unmount partition # $ sudo rm /mnt/f1.dat /mnt/f2.dat /mnt/f3.dat $ md5sum /mnt/* 6fc531ba0b479e701f2d17b3650ae3ee /mnt/f4.dat 29219b88e29d15b366b684ae63a5929d /mnt/f5.dat $ sudo umount /mnt # # - Shrink partition to 300 MiB in GParted # # - Mount partition, show MD5SUM for files (should be same as above). # $ sudo mount /dev/sdb1 /mnt $ md5sum /mnt/* 6fc531ba0b479e701f2d17b3650ae3ee /mnt/f4.dat 29219b88e29d15b366b684ae63a5929d /mnt/f5.dat $ sudo parted /dev/sdb unit s print # # - Show partition table # $ sudo parted /dev/sdb unit s print Model: VMware, VMware Virtual S (scsi) Disk /dev/sdb: 4194304s Sector size (logical/physical): 512B/512B Partition Table: msdos Disk Flags: Number Start End Size Type File system Flags 1 2048s 616447s 614400s primary fat32 # # - unmount partition # $ sudo umount /mnt --------------------------------------------------
