On Fri, May 06, 2022 at 10:15:49AM -0700, Brian C. Lane wrote: > Overall I like it, but have some comments and requests (this covers both > patches):
All done. > Questions > * Should this be added to the machine output? > I think so. Now is probably the best time to break this :) > It can also wait and be done in a later patch, so shouldn't block > the other changes. Fine for me. There have been some other ideas for the output in the past (e.g. partition type: primary, extended, logical). Those could be added all at once. > * Should a column be added to plain output? Maybe with a --verbose option? Maybe --details is better. I think --verbose is more often used for more verbose logging. ciao Arvin -- Arvin Schnell, <[email protected]> Senior Software Engineer, Research & Development SUSE Software Solutions Germany GmbH Maxfeldstraße 5 90409 Nürnberg Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
