On Mon, 12 Dec 2022 at 19:03, Brian C. Lane <[email protected]> wrote: > > On Sun, Dec 11, 2022 at 10:29:21AM +0000, Mike Fleetwood wrote: > > Add user requested support for GPT partition type attribute bit 63 [1] > > so the no-auto flag in the systemd originated Discoverable Partitions > > Specification [2] can be manipulated. The UEFI specification [3] says > > partition attribute bits 48 to 63 are partition type specific, however > > the DPS [2] and Microsoft [4] use the bit 63 to mean no automounting / > > assign no drive letter and apply it to multiple partition types so don't > > restrict its application. > > Thanks for adding this. It needs tests, and while I feel a bit silly for > asking, I think it needs to be no_automount with an underscore. I > should caught linux-home when it was added, but missed it. All the other > flags use underscores so let's stick with that. > > Brian
This new flag is already tested by t3310-flags.sh. It queries the available flags and tests them all. $ cd tests $ make check TESTS=t3310-flags.sh $ grep automount t3310-flags.log hidden, legacy_boot, linux-home, no-automount boot, hidden, legacy_boot, esp, no-automount swap, hidden, legacy_boot, no-automount hidden, legacy_boot, no-automount raid, legacy_boot, no-automount lvm, legacy_boot, no-automount ... Posting patch v2 which just renames the flag to no_automount. Mike
