I'm not sure I understand the patch fully though; why did you remove the print_all functionality and replace it with print_list?
I just renamed the function, since although we have 'print list' and 'print all' doing the same thing, we have '--list' instead of '--all' as the command line switch similar to 'fdisk -l'. Hence I gave preference to 'list' instead of 'all' to ensure consistency.
print_all method prints _detailed_ information for _all_ devices; while print_list method should print a small not-so-detailed of the devices availble (like fdisk -l; discussed before).
'print list' and 'print all' are supposed to do the same thing. This is because '--list/-l' are supposed to be a direct interface to 'print all'. However the '--list/-l' switch and 'print all' commands seem to be inconsistent. Hence it was decided (on this thread) to have 'print list' and 'print all' do the same thing, and not have a '--all/-a' switch since that would be too much redundancy and the '-a' switch might be needed somewhere else in future. Leslie, I hope I am correct. :-) Happy hacking, Debarshi -- Universities are places of knowledge. The freshman each bring a little in with them, and the seniors take none away, so knowledge accumulates. _______________________________________________ parted-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/parted-devel
