Otavio Salvador <[EMAIL PROTECTED]> wrote: >>>> -test_expect_success \ >>>> - 'create expected output file' \ >>>> - 'test $fail = 0' >>>> +test_expect_success 'create expected output file' 'test $fail = 0' >>> >>> This shouldn't be done on same patch. >> >> Considering that is such a small, zero-semantic-content change, >> I deliberately chose not to put it in a patch all by itself. >> IMHO, it's not even worth a log entry. > > Well, while it's trivial and without semantic changing I still prefer > to avoid those changes. It's the same case when we deny indentation > fixes together with other patches. > > Please, review it.
The general *guideline* to avoid mixing formatting changes and non-formatting changes is intended to make the reviewer's job easier by not obscuring "real" changes with unrelated, syntax-only changes. The goal (at least in my mind) is not to require that every tiny formatting change be separated out into its own change set. If you take such an extreme approach, that raises the bar too high, in that it requires a log entry even for small formatting changes, which means such changes are less likely to be made. If you are adamant, I will (reluctantly) take the time to separate out that particular change. _______________________________________________ parted-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/parted-devel
