On 11/14/07, Debarshi 'Rishi' Ray <[EMAIL PROTECTED]> wrote: > I have looked into it properly, but if this is correct then you should > remove the following line as well: > > /* FIXME: this can probably be done more efficiently */
True, but I wanted to get this acked before that. More specifically, 1) Is this really better than the old implementation? I checked it for sanity(correctness), not performance. From my review, this code has a upper bound on how many passes it takes to calculate the logarithm and so may be better than before the change. 2) Is it acceptable to reuse code from wikipedia? Is the content (under GFDL) acceptable in parted code? Also, can the following comment be removed? /* FIXME: move this out to the prospective math.c */ Or is there a plan to do this? Regards, Frodo B _______________________________________________ parted-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/parted-devel
