"Bryn M. Reeves" <[EMAIL PROTECTED]> wrote: > Joel Andres Granados wrote: >> Jim Meyering wrote: >>> Hi Joel, >>> >>> Thanks for the patch. >>> Deprecating ext3 support is a good first step. >> >> yep, its all good. My idea is not to take it away completely though. The >> more I think about this issue the more I realize why it was put there in the >> first place. >> Reasons that I think we should support ext3: >> 1. There is a library, makes things easier and makes stuff less prone to >> bugs. > > Which library do you mean here? The last time I looked the library > interfaces provided by e2fsprogs were themselves quite low-level. E.g. > resize2fs is implemented on top of libext2fs but all the smarts for the > resize operation are implemented in resize2fs itself (apart from online > which relies more on kernel support). > > I think it is unwise to reinvent this kind of low-level file system > manipulation code - if there's no direct library interface available I > would prefer to wrap the executables rather than implement it in parted > (or anywhere for that matter) and repeat the mistakes of > libparted/fs/ext2/ext2_resize.c.
Thanks for writing all that. That was exactly my impression when I looked into making parted use e2fsprogs library code. I certainly did not want to duplicate all of that logic in parted. _______________________________________________ parted-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/parted-devel
