On Tue, Feb 17, 2009 at 09:39:48AM +0100, Jim Meyering wrote: > Jim Meyering <[email protected]> wrote: > ... > > In the process, I discovered a GPT-related bug that > > would provoke a failed assertion. So I fixed that. Patch below. > > Would you like to write the test case for *it*? > > If so, please name it t0201-gpt.sh, since it'll be > > very similar to the one below (which has a FIXME > > comment I plan to address before pushing). > > > > My plan for tomorrow: > > > > - apply your patch, and test a little > > - address FIXME comment in the test script below > > - ensure that the test passes > > - push your patch and the test-adding one > > Petr, > > Here are the results of the above. > > Changes I've made: > - adjusted your commit log comments (it's not specific to > interactive use) > - added a "default: break;" case, to make that choice explicit, > and to avoid compile-time warnings > - addressed the FIXME comment in my test, made quoting more > consistent, and tweaked a string or two > > I'll wait an hour or two, in case you have comments.
Hi Jim, I'm fine with the changes you've made. Thanks -- Best regards / s pozdravem Petr Uzel, Packages maintainer --------------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: [email protected] Lihovarská 1060/12 tel: +420 284 028 964 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz _______________________________________________ parted-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/parted-devel
