Hello Joel, On Wed, Jun 3, 2009 at 9:15 AM, Joel Granados <[email protected]> wrote: > In summary, and to clarify my stand on this issue: > I agree that there might be "cons" regarding individual function > comments in the commit log. > a. Make the developer think that the function doc is already written > b. The commit comment is not in sync with the commit. > c. The specific commit function comment repeats stuff that is said in the > main > commit message. > d. The commit function comment becomes extensive and gives too much info. > > But, if the commit function comments don't fit in (a-d), and they are > sound, and they actually add some context when reading the log, I would > accept the patch.
I fully agree. It can be of great value for people finding by information in log but, as coding standards, we will need to use good sense as a metric in final decision. -- Otavio Salvador O.S. Systems E-mail: [email protected] http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br _______________________________________________ parted-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/parted-devel
