Otavio Salvador wrote: > Hello Jim, > > On Wed, Jun 10, 2009 at 4:23 PM, Jim Meyering<[email protected]> wrote: >> Joel Granados Moreno wrote: > [...] >> - adjust formatting, as below: >> >>> + if (!command_line_get_disk_type (_("New disk label type?"), >>> + &type)) > > I think we shouldn't take coding style so hard. This is quite ugly and > spliting it just due few chars gives nothing to us. I bet we all use a > terminal to program that can show way more then 80 columns.
Hi Otavio, You mention the 80-col limit, yet quote an example with a continued arg-list that is not aligned with the opening parenthesis. Which is it? Well, actually, it doesn't matter which, since I believe that it's worthwhile to follow both. The 80-column limit *is* important. I've missed bugs in review because the buggy part wrapped and thus became less readable. Likewise, with side-by-side diffs, or 3-way merge GUIs things can easily be too wide. _______________________________________________ parted-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/parted-devel
