FYI, This is the first step towards improving the CRC-checking situation in GPT.
>From 757bb2d063dd8e56180a735a5a2f40dbc42ac500 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[email protected]> Date: Wed, 14 Oct 2009 11:36:47 +0200 Subject: [PATCH] tests: gpt: do not munge GPT data manually Otherwise, an upcoming change would cause this test to fail. * tests/t5000-tags.sh: Do not munge GPT data manually, since that does not update embedded CRCs, and thus renders it invalid. Set the attribute via "set 1 bios_grub on" instead. Also, use "name1" as the partition name, rather than the misleading "primary". Adjust diagnostics: the changes we make are no longer "manual." --- tests/t5000-tags.sh | 18 ++++++++---------- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/tests/t5000-tags.sh b/tests/t5000-tags.sh index c5afbc2..9c3e47d 100755 --- a/tests/t5000-tags.sh +++ b/tests/t5000-tags.sh @@ -55,23 +55,21 @@ test_expect_success \ test_expect_success \ 'add a partition' \ - 'parted -s $dev u s mkpart primary ${start_sector} ${end_sector} >out 2>&1' + 'parted -s $dev u s mkpart name1 ${start_sector} ${end_sector} >out 2>&1' test_expect_success \ - 'print the table (before manual modification)' \ + 'print the table before modification' \ ' parted -m -s $dev unit s print > t 2>&1 && sed 's,.*/$dev:,$dev:,' t >> out ' -# Using bios_boot_magic='\x48\x61' looks nicer, but isn't portable. -# dash's builtin printf doesn't recognize such \xHH hexadecimal escapes. -bios_boot_magic='\110\141\150\41\111\144\157\156\164\116\145\145\144\105\106\111' - -printf "$bios_boot_magic" | dd of=$dev bs=$ss seek=2 conv=notrunc +test_expect_success \ + 'set the new bios_grub attribute' \ + 'parted -m -s $dev set 1 bios_grub on' test_expect_success \ - 'print the table (after manual modification)' \ + 'print the table after modification' \ ' parted -m -s $dev unit s print > t 2>&1 sed 's,.*/$dev:,$dev:,' t >> out @@ -82,10 +80,10 @@ gen_exp() cat <<EOF BYT; $dev:${N}s:file:$ss:$ss:gpt:; -1:${start_sector}s:${end_sector}s:${part_sectors}s::primary:; +1:${start_sector}s:${end_sector}s:${part_sectors}s::name1:; BYT; $dev:${N}s:file:$ss:$ss:gpt:; -1:${start_sector}s:${end_sector}s:${part_sectors}s::primary:bios_grub; +1:${start_sector}s:${end_sector}s:${part_sectors}s::name1:bios_grub; EOF } -- 1.6.5.1.258.g5b20 _______________________________________________ parted-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/parted-devel
