On Wed, Nov 02, 2011 at 04:26:24PM +0100, Jim Meyering wrote: > Petr Uzel wrote: > ... > >> Would you please suggest a patch on top of these 4 (which I plan > >> to merge into yours) that fixes the new failing test? > > > > What about the one below? > ... > > Subject: [PATCH] parted: fix test failing because of incomplete mkpart & > > IEC units feature > > > > Prior to this fix, if the user specified default unit as one of the IEC > > ones, but yet used explicit ending sector, parted did adjust the ending > > sector, which is unwanted. Fix by checking the default unit only if no > > unit is specified explicitly. > > > > * parted/parted.c (_string_has_unit_suffix): New function. > > (_adjust_end_if_iec): Use _string_has_unit_suffix. > > * tests/t0208-mkpart-end-in-IEC.sh: Add missing colon to expected > > output. > ... > Thanks. Folded into your two change-sets below, > along with all other feedback. > > Please review. I'll push if/when you ACK.
Reviewed and ACKed.
Thanks,
Petr
--
Petr Uzel
IRC: ptr_uzl @ freenode
pgpLdkBPoljo2.pgp
Description: PGP signature
