On Fri, Nov 04, 2011 at 09:39:01PM +0100, Jim Meyering wrote: > > Thanks for the patch. > In testing it, I realized that we were not exercising the > >512-byte-sector paths, because the device we created would > always have sector size of 512. I was thinking about that because > with your smaller (8MB) disk, the 8000s partition shouldn't fit > for sector sizes of 1024 and larger, yet the test was passing. > > The first step is to use the test-specified sector size when > creating the scsi_debug device. That's the added sector_size=$ss arg. > The next is to reduce further the partition size to 800. Then, > even with 4Kb sectors, the partition still fits easily. > > Finally, in the spirit of never waiting even a second, unless > absolutely necessary I've replaced your loop with a use of the > just written wait_for_dev_to_disappear_ function. > So, I'll merge the following changes into your patch and > push that after the helper-adding commit at the end. > > I'll push after you ACK.
Looks good, thanks! -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgpILp91lh5Sj.pgp
Description: PGP signature
