On 1/3/2012 3:03 AM, Jim Meyering wrote:
Thanks for the patch. I like the sound of it. Would you please write a NEWS entry for it? Also, this will require a test to exercise the new behavior.
I'm a little unsure how to write such a test. Testing the grown disk part is easy, but testing the backup in the wrong place part requires manually munging the backup location. I suppose I could intentionally break parted and use it to build a hand crafted image file to test on, but I don't see a directory with pre-created images for testing. Would this be acceptable?
Also, please run this in your parted clone directories, git config format.signoff true That arranges to suppress those Signed-off-by lines. When you're the Author, an identical Signed-off-by line is just clutter.
I always thought so too, but the guys on lkml want it as some sort of indicator that yes, you're ok with the code being gpl ( I'm submitting a patch aren't I? ), so I got in the habit of adding -s to format-patch. I'll not bother from now on for parted.
