On Thu, Sep 17, 2015 at 03:33:27PM +0200, Hendrik Brueckner wrote: > The current fdasd code present in parted prevents DASDs attached > non-natively, for example, through virtblk, from being recognized > as such and, thus, prevent proper partitioning. > > The following changes are implemented in this series: > > 1. Update parted with fdasd.c code from s390-tools to not rely on > the DASD specific ioctl's anymore. > > 2. Adapt the parted code to be able to handle disks in DASD format > irrespective of the used block device driver. > > 3. Add protection against messing up non-DASD block devices through > better error checking. > > > Changes in the v2 series: > - Use translatable strings and enhanced error handling. > - Avoid API changes > > > Viktor Mihajlovski (2): > fdasd: geometry handling updated from upstream s390-tools > dasd: enhance device probing > > include/parted/fdasd.in.h | 4 +- > libparted/arch/linux.c | 85 +++++++++++++++++++---- > libparted/device.c | 14 +--- > libparted/labels/dasd.c | 18 ++--- > libparted/labels/fdasd.c | 166 > +++++++++++++++++++++++++++++++-------------- > 5 files changed, 201 insertions(+), 86 deletions(-)
Thanks for the changes, these look good to me. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

