On 16 August 2016 at 20:42, Mike Fleetwood <[email protected]> wrote: > Hi, > > We had a user report an error in GParted when creating a partition on > a BSD table. Turns out that setting the lvm flag on a bsd table reports > failure. There is a missing return 1 (success) when setting the lvm > flag in bsd_partition_set_flag() so it falls through to the failure > return. > > The relevant fix is: > libparted: Fix to report success when setting lvm flags on bsd table > > Most of the other changes are incrementally changing t3310-flags.sh to > test nearly all the flags of all the supported partition types. > > Bug 769831 - Formatting a partition on a BSD table fails at step: > set partition type > https://bugzilla.gnome.org/show_bug.cgi?id=769831 > > Thanks, > Mike > > Mike Fleetwood (8): > tests: t3310-flags.sh: List all the flags to be tested > tests: t3310-flags.sh: Stop excluding certain flags from being tested > tests: t3310-flags.sh: Add test for bsd table flags > libparted: Fix to report success when setting lvm flag on bsd table > libparted: Remove commented local variable from > bsd_partition_set_flag() > tests: t3310-flags.sh: Add test for mac table flags > tests: t3310-flags.sh: Add test for dvh table flags > tests: t3310-flags.sh: Add tests for remaining table types > > libparted/labels/bsd.c | 2 +- > tests/t3310-flags.sh | 81 ++++++++++++++++++++++++++++++++++------------- > 2 files changed, 59 insertions(+), 24 deletions(-) >
Ping. Any thoughts on these patches.
