Re: the JPEG compression patch. Agreed, the UI is annoying, so is the fiddling with the parameters. I could not think of a good way to determine ahead of time whether a portion of a refreshed window would compress better as JPEG compared to straight ZIP. JPEG obviously has advantages with complex images; ZIP is better for images containing simple text. So I suppose one could do some (hopefully simple) statistical analysis of the image data to be transferred and choose JPEG/ZIP based on that. Or one could compress with both methods on the server and then decide. It all depends on the bandwidth/CPU power ratio.
-- Lars ----- Original Message ---- From: Nathaniel Smith <[email protected]> To: Antoine Martin <[email protected]> Cc: [email protected] Sent: Sat, November 7, 2009 1:56:21 AM Subject: Re: [Parti-discuss] patches On Tue, Oct 13, 2009 at 8:11 AM, Antoine Martin <[email protected]> wrote: > For those who still want to get a better xpra, here they are. Including > fixes, MS Windows support, a gui launcher, avoids triggering apport on > karmic, jpeg compression...: > http://xpra.devloop.org.uk/patches/ I just did a quick pass through these: avoid-apport-whenkilled.patch: Fails to apply. What is it trying to do? bug-xerror-undef-var.patch: Applied. catch-socket-error.patch: ...this is the same as avoid-apport-whenkilled.patch? cleanup-parti-main-unusedimport.patch: Fixed in a better way. cleanup-parti-scripts-unusedvars.patch: (options, args) = parser.parse_args(...) is idiomatic; this patch makes the code harder to read, not easier... cleanup-wimpiggy-prop-unusedimportsandvars.patch: Applied the part of this that I like. cleanup-wimpiggy-unusedimportsandvars.patch: Applied the parts of this that I like. cleanup-xpra-scripts-unusedimportsandvars.patch: Ditto. cleanup-xpra-unusedimportsandvars.patch: Ditto. cleanup-yatest-whitespace-import.txt: Ditto. client_launcher.py: This could be integrated as 'xpra gui-attach' or something, I suppose...? missing-sys-import.patch: Already fixed in trunk. set-socket-timeout.patch: Applied. xvfb-bin.patch: Rewrote in a slightly way, and documented. It is now called "--xvfb", in line with the existing --ssh and --remote-xpra. xpra-name-windows.patch: Can you remind me what the point of this is? jpeg-compression.patch: Deferring until I can think about it more... the UI seems annoying, in that really xpra should be smart enough to use jpeg only when it matters, not require you to fiddle with some magic knobs that most users won't discover or know how to tweak properly. (I'm not at all sure how to tweak them myself... does using jpeg even actually help in practice? How was this measured and what levels of compression worked best?) mswindows-cant-clipboard-asis.patch mswindows-conditional-pyrex.patch mswindows-disable-server-code-in-main.patch mswindows-exec-main.patch mswindows-ignore-sendclientmessage.patch mswindows-keyboard-not-impl.patch mswindows-move-common-parts.patch -- Continuing to defer these until there's a chance to get it right. xpra-allow-bind-to-all-interfaces.patch password-file.patch password-secure.patch password.patch -- Okay, seriously: Why do you care about TCP? Is it just because implementing ssh support on windows is hard? Because I keep asking this, and I keep not getting an answer, just more and more patches to enhance an option that is fundamentally insecure and misleads users into doing insecure things. Please? -- Nathaniel _______________________________________________ Parti-discuss mailing list [email protected] http://lists.partiwm.org/cgi-bin/mailman/listinfo/parti-discuss _______________________________________________ Parti-discuss mailing list [email protected] http://lists.partiwm.org/cgi-bin/mailman/listinfo/parti-discuss
