Hi,
It's great that pass ships with completions for fish. Recently, there's
been a request[1] that they get included directly into fish, but I think
it's best that they are maintained and installed as part of pass.
In order to avoid conflicts between completions shipped with fish and
third-party completions, with the next release of fish[2] we will be
recommending that all completions get installed into
`DATADIR/share/fish/vendor_completions.d`. The attached patch changes the
Makefile to do so.
The most preferable option would be to try calling `pkg-config
--variable=completionsdir fish` and using the output of that, but there's
no guarantee that pkg-config exists on all platforms, and stuffing the
output of a shell command into a Make variable is difficult to get working
across BSD & GNU Make, so I've left that for now.
Thanks,
David Adam
fish committer
[email protected]
[1]: https://github.com/fish-shell/fish-shell/pull/1843
[2]: https://github.com/fish-shell/fish-shell/issues/1485
From 0f746ac9e4ca074396383ca788bdc88e43a496b6 Mon Sep 17 00:00:00 2001
From: David Adam <[email protected]>
Date: Thu, 4 Dec 2014 21:07:40 +0800
Subject: [PATCH] fish: install completions in preferred directory
Signed-off-by: David Adam <[email protected]>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index f877d74..7546fa9 100644
--- a/Makefile
+++ b/Makefile
@@ -8,7 +8,7 @@ PLATFORMFILE := src/platform/$(shell uname | cut -d _ -f 1 | tr '[:upper:]' '[:l
BASHCOMP_PATH ?= $(DESTDIR)$(PREFIX)/share/bash-completion/completions
ZSHCOMP_PATH ?= $(DESTDIR)$(PREFIX)/share/zsh/site-functions
-FISHCOMP_PATH ?= $(DESTDIR)$(PREFIX)/share/fish/completions
+FISHCOMP_PATH ?= $(DESTDIR)$(PREFIX)/share/fish/vendor_completions.d
ifeq ($(FORCE_ALL),1)
FORCE_BASHCOMP := 1
--
2.0.1
_______________________________________________
Password-Store mailing list
[email protected]
http://lists.zx2c4.com/mailman/listinfo/password-store
