Hi, I totally agree with the fact that there are priorities. Being myself the maintainer of several projects I sometimes take several weeks to give a proper answer. What confuses me here is that I got no answer at all, neither positive nor negative, in 8 months (first submition was in July 2014, way before 1.6.5).
Regarding your remarks, maybe a configuration file could be a solution as an alternative to current env-vars + .gpg-id + some extra configuration like clipboard managers. Regards, Marc-Antoine On 13 March 2015 at 23:39, Lenz Weber <[email protected]> wrote: > Hi Marc-Antoine, > the only person that can do that kind of review is the Maintainer, Jason > - and he has not been very active since the release of 1.6.5. > > I guess he is just occupied with something else at the moment - from > what I've seen on this list it's not the first time and will not be the > last time. > While I understand that the waiting game can be frustrating (I have a > pending merge request on this list, too, although I have to admit that > you are waiting far longer than me and I can absolutely understand your > frustration), we have to respect that sometimes other things than "being > project maintainer" can have a high priority. > > As for your commit: I guess it's one of those "difficult" ones, as it > changes behaviour without the user really noticing (if the user has > gpaste and xclip installed and updates password-store, it used xclip > before and gpaste after), so it's not easily merged, but a real design > decision. > Also supporting two clipboard managers instead of one of course will > lead to the adoption of a third, etc. > > So there are some points that could weaken the impact of this design > decision - but I could be wrong on some of these: > * describe more in-depth the impact of the patch in the commit message, > so it can easily be pasted to the ChangeLog, which will hopefully reach > end users > * keep some way of allowing the user to use xclip over gpaste without > having to uninstall gpaste. maybe a flag, maybe an environment variable, > maybe an environment variable at "make install" time. I'm not sure which > of these would be the preferred way. > * maybe move all clipboard-manager code to an extra file, just like it > is done with the platform-dependend code? With enough thougt to this, > this could allow for the addition, selection and configuration of > multiple additional clipboard managers without cluttering the main code. > > Aside from that, we can only wait. But be sure, you're not the only one > > Regards, > Lenz > > > On 13.03.2015 13:14, Marc-Antoine Perennou wrote: >> Still no review on this… >> What is the correct way of getting at least a yes/no if this list isn't? >> >> Regards, >> Marc-Antoine >> >> >> >> >> On 5 Feb 2015 21:35:45 CET, Marc-Antoine Perennou >> <[email protected]> wrote: >>> GPaste is a clipboard which now supports password natively without writing >>> them to its history file and displaying a given name to identify them. >>> >>> Signed-off-by: Marc-Antoine Perennou >>> --- >>> src/password-store.sh | 16 +++++++++++++++- >>> 1 file changed, 15 insertions(+), 1 deletion(-) >>> >>> diff --git a/src/password-store.sh b/src/password-store.sh >>> index d10b7c2..4d6a51a 100755 >>> --- a/src/password-store.sh >>> +++ b/src/password-store.sh >>> @@ -131,6 +131,14 @@ clip_sleep() { >>> ( exec -a "$1" sleep "$CLIP_TIME" ) >>> } >>> >>> +clip_gpaste() { >>> + gpaste add-password "$3" "$2" || die "Error: Could not copy data to >>> the clipboard" >>> + ( >>> + clip_sleep "$1" >>> + gpaste delete-password "$3" >>> + ) 2>/dev/null & disown >>> +} >>> + >>> clip_xclip() { >>> # This base64 business is because bash cannot store binary data in a shell >>> # variable. Specifically, it cannot store nulls nor (non-trivally) store >>> @@ -158,7 +166,13 @@ clip_xclip() { >>> clip() { >>> local sleep_argv0="password store sleep on display $DISPLAY" >>> pkill -f "^$sleep_argv0" 2>/dev/null && sleep 0.5 >>> - clip_xclip "$sleep_argv0" "$@" >>> + local gpaste=0 >>> + gpaste help | grep -q password && gpaste=1 >>> + if [[ $gpaste -eq 1 ]]; then >>> + clip_gpaste "$sleep_argv0" "$@" >>> + else >>> + clip_xclip "$sleep_argv0" "$@" >>> + fi >>> echo "Copied $2 to clipboard. Will clear in $CLIP_TIME seconds." >>> } >>> >>> -- >>> 2.2.2 >>> >> >> >> _______________________________________________ >> Password-Store mailing list >> [email protected] >> http://lists.zx2c4.com/mailman/listinfo/password-store >> > _______________________________________________ > Password-Store mailing list > [email protected] > http://lists.zx2c4.com/mailman/listinfo/password-store _______________________________________________ Password-Store mailing list [email protected] http://lists.zx2c4.com/mailman/listinfo/password-store
