On Fri, 23 Mar 2018 10:32:41 +0100, Lars Flitter
<[email protected]> wrote:

>+      git -C "$INNER_GIT_DIR" add "$(readlink -f "$1")" || return
>+      [[ -n $(git -C "$INNER_GIT_DIR" status --porcelain "$(readlink -f 
>"$1")") ]] || 

I'm not saying this patch is bad, but my first thought is to be very
careful using readlink and/or realpath.  They're very inconsistently
implemented across platforms.  Even on Linux it's difficult to depend
on them as some distros use the GNU coreutils version and some don't.
OSX uses a BSD flavor that has different flags.

_______________________________________________
Password-Store mailing list
[email protected]
https://lists.zx2c4.com/mailman/listinfo/password-store

Reply via email to