Hello Thomas,

Thomas Walter writes:
> [...]
> Long story short, see attachment. I am not sure if other sed's need
> similar treatment or if other $PASSWORD_STORE_GPG_OPTS need changing
> too. And I've only tested it on OSX so far.
> [...]

(No idea regarding $PASSWORD_STORE_GPG_OPTS change, I'll just comment
about the (incorrect) basic regular expression...)

The `-E' option seems already passed to other sed(1) invocations
so probably this will not be a problem.

I have locally applied your patch on pass 1.7.3 on NetBSD where
previously by running the tests:

 | not ok 10 - Reencryption root group to identical individual with no file 
change
 | #
 | #               
oldfile="$SHARNESS_TRASH_DIRECTORY/$RANDOM.$RANDOM.$RANDOM.$RANDOM.$RANDOM" &&
 | #               "$PASS" init group1 &&
 | #               cp "$PASSWORD_STORE_DIR/folder/cred1.gpg" "$oldfile" &&
 | #               "$PASS" init $KEY4 $KEY2 &&
 | #               test_cmp "$PASSWORD_STORE_DIR/folder/cred1.gpg" "$oldfile"
 | #

...but with just the RE adjustment now all the tests passed!
I guess that it probably worked by accident and only with GNU sed:

 % echo "test: ABC123" | sed -n 's/^test: \([A-F0-9]\+\)$/\1/p'
 % echo "test: ABC123" | gsed -n 's/^test: \([A-F0-9]\+\)$/\1/p'
 ABC123


Nice catch and thank you very much!
_______________________________________________
Password-Store mailing list
[email protected]
https://lists.zx2c4.com/mailman/listinfo/password-store

Reply via email to