On 23 Oct 2018, at 18:11, [email protected] wrote:

But you are right in one part, Amir. Just because brew or macports are installed doesn't mean that gnu-getopts was installed with either tool. Therefore, we should check if either is installed AND if gnu-getopt is in the path we assume. If nothing is true, then (and only then) use any reasonable fall back.

But I have to think about it and make a diff as soon as I am ready.

At least for homebrew, the `pass` formula depends on `gnu-getopt`, therefor only a user who has `brew` installed but who did a custom install of `pass`, could run into an issue of missing `gnu-getopt`.

I think such scenario is unlikely, especially as `brew` allows installing `pass` directly from git (using `HEAD`).

Also, if it is desirable with additional fault tolerance, I would argue it belongs in a different commit, as it’s unrelated to the optimization that is being proposed.
_______________________________________________
Password-Store mailing list
[email protected]
https://lists.zx2c4.com/mailman/listinfo/password-store

Reply via email to