On Oct 30, 2018, at 12:00 AM, Adhityaa Chandrasekar <[email protected]> wrote:

> +     if [[ "$wordlist" != "" ]]; then
> +             pass=$(shuf -n 4 "$wordlist" | paste -sd "-" -)
> +     else

While I think the concept is a good one, I don't think we should be depending 
on the user having "shuf" installed on their machine.  I don't have it on mine, 
and I've installed a whole boatload of extra stuff that most people don't have.

I'm also not sure about "paste", although I do happen to have a program by that 
name on my machine.

IMO, you're better off sticking to more standard *nix utilities.

-- 
Brad Knowles <[email protected]>

Please forgive any typos.  I'm fighting a failing keyboard on my laptop, in 
addition to having a broken finger.

_______________________________________________
Password-Store mailing list
[email protected]
https://lists.zx2c4.com/mailman/listinfo/password-store

Reply via email to