Sorry I'm sending yet another email, but be careful with tabs/spaces, you are mixing them in the patch. Many lines are not actually changed except for the mix, that is not nice.
I'm surprised that shellcheck didn't complain about lines 26, 58, 73, 96, 98, 141 (of the patch, don't know its correspondences with the code). Other than that, seems ok :) Cheers! On 5/18/19 7:18 PM, ಚಿರಾಗ್ ನಟರಾಜ್ wrote: > Copy that! > > I fixed many (but not all) of the warnings. Two we can't _really_ do anything > about (the SC1090s) and two I'm not quite sure how to fix. After my > modifications, it passes all the tests, which is a good sign, but there's > definitely a chance I misinterpreted something in the code. > > Sincerely, > > Chiraag -- HacKan || Iván GPG: 0x35710D312FDE468B _______________________________________________ Password-Store mailing list [email protected] https://lists.zx2c4.com/mailman/listinfo/password-store
