The patch looks good.

On Mon, Jun 3, 2019, at 00:16, Victor Luft wrote:
> This commit will short circuit git_add_file if the argument
> is ignored, and is compatible back to at least git 2.3.0.

For environments with older versions of Git (pre- v1.8.2-rc0), it is trading one
noisy error in a corner case with another noisy error on every call to
git_add_file(). A simpler way to silence the `git add` command would be to send
its stderr to /dev/null, if that is acceptable in this project.

Regards,
Amir
_______________________________________________
Password-Store mailing list
[email protected]
https://lists.zx2c4.com/mailman/listinfo/password-store

Reply via email to