On Tue, Oct 8, 2019, at 17:32, Devin Smith wrote:
> - grouping = DEFAULT_GROUP if grouping == nil
> + grouping = DEFAULT_GROUP if grouping.empty?

> Although - it looks like this line was intentionally changed 
> https://git.zx2c4.com/password-store/commit/contrib/importers/lastpass2pass.rb?id=85757e99bff29d6fa663a6b291c9047ccce8c6d3.
> 
> I'm not familiar with ruby, but here is my version:

To cover both the nil and empty string cases, one might check for 
`grouping.to_s.empty?`.
_______________________________________________
Password-Store mailing list
[email protected]
https://lists.zx2c4.com/mailman/listinfo/password-store

Reply via email to