On Tue, Jun 15, 2021 at 08:17:07AM +0200, Dan Čermák wrote: > Johannes Altmanninger <[email protected]> writes: > > > On Mon, Jun 14, 2021 at 11:03:48PM +0200, Dan Čermák wrote: > >> Afaik fish shell completions don't need a shebang > >> (plus the script is not executable anyway) > > > > Yeah, that is the convention - I didn't make this change because it breaks > > syntax highlighting in my editor. > > This is because my editor recognizes fish filetypes based on > > 1. file extension (".fish") > > - but "pass.fish-completion" does not follow that convention > > 2. output of "file --mime" > > - without the shebang, file(1) no longer recognizes that this is a shell > > script. > > Apologies, I was not aware that this would be a potential fallout. If > the modelines are not really viable alternatives, then my patch can be > reverted, as it does not really fix anything.
Nah, I think it's fine. Missing syntax highlighting is really minor. If someone took a look at whether shebang or modelines work better, then we would have a reason to use either one, but it's hardly worth the time.
