I am in favour of incorporating this patch, LGTM.

Just curious: what motivated you to make this change? Did your try to run pass 
in an environment without `which`, or did `which` exit with an erroneous 
success status for you?

On Wed, 15 Sep 2021, at 20:17, Ayush Agarwal wrote:
> The 'which' command is an external command that must be called each and
> every time pass is used. 'which' is also not mentioned in the README as
> one of the dependencies that might be needed to run pass.
> 
> Instead of 'which', we can use the POSIX compatible and shell built-in
> 'command -v'. It saves pass from making an external call and is,
> arguably, more reliable than using 'which' as mentioned in the following
> link.
> 
> <https://mywiki.wooledge.org/BashFAQ/081>

Reply via email to