On Fri, Jul 13, 2012 at 2:13 PM, Philip Balister <phi...@balister.org> wrote: > On 07/13/2012 11:10 AM, Jaroslav Skarvada wrote: >> >> Hi, >> >> the NEON optimisation is always used on all ARMs, even if not >> supported. Another problem is that in Fedora we build with >> -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=hard, so >> the compilation fails even on machine with NEON. >> >> The proposed patch adds guard to NEON assembly code and the guard >> depends on have_mfpu_neon cmake internal variable. The value of >> this variable is autodetected during cmake initialisation, but >> can be also overriden by e.g.: > > > > Do you know if this works for cross compiling? I assume it can be forced on > regardless? > > Philip > >> >> cmake -Dhave_mfpu_neon=0 >> >> The performance/usability of binary compiled without NEON is >> probably not good, but at least it compiles fine on more >> machines. >> >> This issue was originally reported in: >> https://bugzilla.redhat.com/show_bug.cgi?id=837028 >> >> regards >> >> Jaroslav
Jaroslav, Philip, What's the consensus on this patch? It looks sane to me, but any chance of it causing trouble? Thanks, Tom _______________________________________________ Patch-gnuradio mailing list Patch-gnuradio@gnu.org https://lists.gnu.org/mailman/listinfo/patch-gnuradio
