On Mon, Feb 20, 2006 at 12:44:38AM -0700, [EMAIL PROTECTED] wrote: > > Description: Removes Dependency of tempfile
Is a patch really necessary when the following works perfectly well? sed -i 's|tempfile -d /tmp -p bz|mktemp|' bzdiff ############################################################# [EMAIL PROTECTED] 3:35am ~ $ /usr/bin/bzdiff mktemp* Binary files - and /tmp/tmp.XXXXWP11Cs differ [EMAIL PROTECTED] 3:35am ~ $ ./bzdiff-patched mktemp* Binary files - and /tmp/mktemp-1.5.tar.18621 differ [EMAIL PROTECTED] 3:35am ~ $ ./bzdiff-sed mktemp* Binary files - and /tmp/tmp.XXXXGkjE6C differ [EMAIL PROTECTED] 3:35am ~ $ /usr/bin/bzdiff test* 1c1 < Sbmitted By: Jim Gifford (patches at jg555 dot com) --- > Submitted By: Jim Gifford (patches at jg555 dot com) [EMAIL PROTECTED] 3:38am ~ $ ./bzdiff-sed test* 1c1 < Sbmitted By: Jim Gifford (patches at jg555 dot com) --- > Submitted By: Jim Gifford (patches at jg555 dot com) [EMAIL PROTECTED] 3:38am ~ $ ./bzdiff-patched test* 1c1 < Sbmitted By: Jim Gifford (patches at jg555 dot com) --- > Submitted By: Jim Gifford (patches at jg555 dot com) ############################################################# > ++ *) bzip2 -cdfq "$1" | $comp $OPTIONS - "$2" | sed -e > "s|Files - and /tmp/"$F".$$|Files $1 and $2|g" I don't think calling sed in the script is really necessary nor prudent here. As for patch vs sed, the sed is very educational and straight forward and would flow quite nicely in a book. It cuts down on one more patch as well. -- Archaic Want control, education, and security from your operating system? Hardened Linux From Scratch http://www.linuxfromscratch.org/hlfs -- http://linuxfromscratch.org/mailman/listinfo/patches FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
