Author: ken
Date: 2008-03-28 16:03:39 -0600 (Fri, 28 Mar 2008)
New Revision: 1933

Added:
   trunk/poppler/
   trunk/poppler/poppler-0.5.4-security_fixes-1.patch
Log:
Vulnerability fixes for poppler.

Added: trunk/poppler/poppler-0.5.4-security_fixes-1.patch
===================================================================
--- trunk/poppler/poppler-0.5.4-security_fixes-1.patch                          
(rev 0)
+++ trunk/poppler/poppler-0.5.4-security_fixes-1.patch  2008-03-28 22:03:39 UTC 
(rev 1933)
@@ -0,0 +1,704 @@
+Submitted By: Ken Moffat <ken at linuxfromscratch dot org>
+Date: 2008-03-28
+Initial Package Version: 1.2.12
+Upstream Status: unknown (the stable poppler was 0.6 when the last of these 
were discovered)
+Origin: Mandriva
+Description: An agglomeration of the four CVE patches in Mandriva
+ poppler-0.5.4-3.3. Fixes CVE-2007-{3387,4352,5392,5393}.  Also
+ their patch for CVE-2007-0104 (0.5.3) which is perhaps not needed,
+ but applies and looks like a good idea.
+
+diff -Naur poppler-0.5.4.orig/poppler/Catalog.cc 
poppler-0.5.4/poppler/Catalog.cc
+--- poppler-0.5.4.orig/poppler/Catalog.cc      2006-09-13 16:10:52.000000000 
+0100
++++ poppler-0.5.4/poppler/Catalog.cc   2008-03-28 20:06:51.000000000 +0000
+@@ -26,6 +26,12 @@
+ #include "UGooString.h"
+ #include "Catalog.h"
+ 
++// This define is used to limit the depth of recursive readPageTree calls
++// This is needed because the page tree nodes can reference their parents
++// leaving us in an infinite loop
++// Most sane pdf documents don't have a call depth higher than 10
++#define MAX_CALL_DEPTH 1000
++
+ //------------------------------------------------------------------------
+ // Catalog
+ //------------------------------------------------------------------------
+@@ -75,7 +81,7 @@
+     pageRefs[i].num = -1;
+     pageRefs[i].gen = -1;
+   }
+-  numPages = readPageTree(pagesDict.getDict(), NULL, 0);
++  numPages = readPageTree(pagesDict.getDict(), NULL, 0, 0);
+   if (numPages != numPages0) {
+     error(-1, "Page count in top-level pages object is incorrect");
+   }
+@@ -217,7 +223,7 @@
+   return s;
+ }
+ 
+-int Catalog::readPageTree(Dict *pagesDict, PageAttrs *attrs, int start) {
++int Catalog::readPageTree(Dict *pagesDict, PageAttrs *attrs, int start, int 
callDepth) {
+   Object kids;
+   Object kid;
+   Object kidRef;
+@@ -262,9 +268,13 @@
+     // This should really be isDict("Pages"), but I've seen at least one
+     // PDF file where the /Type entry is missing.
+     } else if (kid.isDict()) {
+-      if ((start = readPageTree(kid.getDict(), attrs1, start))
+-        < 0)
+-      goto err2;
++      if (callDepth > MAX_CALL_DEPTH) {
++        error(-1, "Limit of %d recursive calls reached while reading the page 
tree. If your document is correct and not a test to try to force a crash, 
please report a bug.", MAX_CALL_DEPTH);
++      } else {
++        if ((start = readPageTree(kid.getDict(), attrs1, start, callDepth + 
1))
++          < 0)
++        goto err2;
++      }
+     } else {
+       error(-1, "Kid object (page %d) is wrong type (%s)",
+           start+1, kid.getTypeName());
+diff -Naur poppler-0.5.4.orig/poppler/Catalog.h poppler-0.5.4/poppler/Catalog.h
+--- poppler-0.5.4.orig/poppler/Catalog.h       2006-01-23 14:43:36.000000000 
+0000
++++ poppler-0.5.4/poppler/Catalog.h    2008-03-28 20:06:51.000000000 +0000
+@@ -193,7 +193,7 @@
+   PageMode pageMode;          // page mode
+   PageLayout pageLayout;      // page layout
+ 
+-  int readPageTree(Dict *pages, PageAttrs *attrs, int start);
++  int readPageTree(Dict *pages, PageAttrs *attrs, int start, int callDepth);
+   Object *findDestInTree(Object *tree, GooString *name, Object *obj);
+ };
+ 
+diff -Naur poppler-0.5.4.orig/poppler/Stream.cc poppler-0.5.4/poppler/Stream.cc
+--- poppler-0.5.4.orig/poppler/Stream.cc       2006-07-28 19:07:41.000000000 
+0100
++++ poppler-0.5.4/poppler/Stream.cc    2008-03-28 20:07:21.000000000 +0000
+@@ -423,9 +423,9 @@
+ 
+   nVals = width * nComps;
+   if (width <= 0 || nComps <= 0 || nBits <= 0 ||
+-      nComps >= INT_MAX/nBits ||
+-      width >= INT_MAX/nComps/nBits ||
+-      nVals * nBits + 7 < 0) {
++      nComps > gfxColorMaxComps || nBits > 16 ||
++      width >= INT_MAX / nComps ||
++      nVals >= (INT_MAX - 7) / nBits) {
+     return;
+   }
+   totalBits = nVals * nBits;
+@@ -436,7 +436,7 @@
+   }
+   pixBytes = (nComps * nBits + 7) >> 3;
+   rowBytes = ((totalBits + 7) >> 3) + pixBytes;
+-  if (rowBytes < 0) {
++  if (rowBytes <= 0) {
+     return;
+   }
+   predLine = (Guchar *)gmalloc(rowBytes);
+@@ -1291,22 +1291,28 @@
+   endOfLine = endOfLineA;
+   byteAlign = byteAlignA;
+   columns = columnsA;
+-  if (columns + 3 < 1 || columns + 4 < 1 || columns < 1) {
++  if (columns < 1) {
+     columns = 1;
++  } else if (columns > INT_MAX - 2) {
++    columns = INT_MAX -2;
+   }
+   rows = rowsA;
+   endOfBlock = endOfBlockA;
+   black = blackA;
+-  refLine = (short *)gmallocn(columns + 4, sizeof(short));
+-  codingLine = (short *)gmallocn(columns + 3, sizeof(short));
++  // 0 <= codingLine[0] < codingLine[1] < ... < codingLine[n] = columns
++  // ---> max codingLine size = columns + 1
++  // refLine has one extra guard entry at the end
++  // ---> max refLine size = columns + 2
++  codingLine = (int *)gmallocn(columns + 1, sizeof(int));
++  refLine = (int *)gmallocn(columns + 2, sizeof(int));
+ 
+   eof = gFalse;
+   row = 0;
+   nextLine2D = encoding < 0;
+   inputBits = 0;
+-  codingLine[0] = 0;
+-  codingLine[1] = refLine[2] = columns;
+-  a0 = 1;
++  codingLine[0] = columns;
++  a0i = 0;
++  outputBits = 0;
+ 
+   buf = EOF;
+ }
+@@ -1325,9 +1331,9 @@
+   row = 0;
+   nextLine2D = encoding < 0;
+   inputBits = 0;
+-  codingLine[0] = 0;
+-  codingLine[1] = refLine[2] = columns;
+-  a0 = 1;
++  codingLine[0] = columns;
++  a0i = 0;
++  outputBits = 0;
+   buf = EOF;
+ 
+   // skip any initial zero bits and end-of-line marker, and get the 2D
+@@ -1344,163 +1350,228 @@
+   }
+ }
+ 
++ inline void CCITTFaxStream::addPixels(int a1, int blackPixels) {
++  if (a1 > codingLine[a0i]) {
++    if (a1 > columns) {
++      error(getPos(), "CCITTFax row is wrong length (%d)", a1);
++      err = gTrue;
++      a1 = columns;
++    }
++    if ((a0i & 1) ^ blackPixels) {
++       ++a0i;
++    }
++    codingLine[a0i] = a1;
++  }
++}
++
++inline void CCITTFaxStream::addPixelsNeg(int a1, int blackPixels) {
++  if (a1 > codingLine[a0i]) {
++    if (a1 > columns) {
++      error(getPos(), "CCITTFax row is wrong length (%d)", a1);
++      err = gTrue;
++      a1 = columns;
++    }
++    if ((a0i & 1) ^ blackPixels) {
++      ++a0i;
++    }
++    codingLine[a0i] = a1;
++  } else if (a1 < codingLine[a0i]) {
++    if (a1 < 0) {
++      error(getPos(), "Invalid CCITTFax code");
++      err = gTrue;
++      a1 = 0;
++    }
++    while (a0i > 0 && a1 <= codingLine[a0i - 1]) {
++      --a0i;
++    }
++    codingLine[a0i] = a1;
++  }
++}
++
+ int CCITTFaxStream::lookChar() {
+   short code1, code2, code3;
+-  int a0New;
+-  GBool err, gotEOL;
+-  int ret;
+-  int bits, i;
++  int b1i, blackPixels, i, bits;
++  GBool gotEOL;
+ 
+-  // if at eof just return EOF
+-  if (eof && codingLine[a0] >= columns) {
+-    return EOF;
++  if (buf != EOF) {
++    return buf;
+   }
+ 
+   // read the next row
+-  err = gFalse;
+-  if (codingLine[a0] >= columns) {
++  if (outputBits == 0) {
++
++    // if at eof just return EOF
++    if (eof) {
++      return EOF;
++    }
++
++    err = gFalse;
+ 
+     // 2-D encoding
+     if (nextLine2D) {
+-      for (i = 0; codingLine[i] < columns; ++i)
++      for (i = 0; codingLine[i] < columns; ++i) {
+       refLine[i] = codingLine[i];
+-      refLine[i] = refLine[i + 1] = columns;
+-      b1 = 1;
+-      a0New = codingLine[a0 = 0] = 0;
+-      do {
++      }
++      refLine[i++] = columns;
++      refLine[i] = columns;
++      codingLine[0] = 0;
++      a0i = 0;
++      b1i = 0;
++      blackPixels = 0;
++      // invariant:
++      // refLine[b1i-1] <= codingLine[a0i] < refLine[b1i] < refLine[b1i+1]
++      //                                                             <= 
columns
++      // exception at left edge:
++      //   codingLine[a0i = 0] = refLine[b1i = 0] = 0 is possible
++      // exception at right edge:
++      //   refLine[b1i] = refLine[b1i+1] = columns is possible
++      while (codingLine[a0i] < columns) {
+       code1 = getTwoDimCode();
+       switch (code1) {
+       case twoDimPass:
+-        if (refLine[b1] < columns) {
+-          a0New = refLine[b1 + 1];
+-          b1 += 2;
++        addPixels(refLine[b1i + 1], blackPixels);
++        if (refLine[b1i + 1] < columns) {
++          b1i += 2;
+         }
+         break;
+       case twoDimHoriz:
+-        if ((a0 & 1) == 0) {
+-          code1 = code2 = 0;
++        code1 = code2 = 0;
++        if (blackPixels) {
+           do {
+-            code1 += code3 = getWhiteCode();
++            code1 += code3 = getBlackCode();
+           } while (code3 >= 64);
+           do {
+-            code2 += code3 = getBlackCode();
++            code2 += code3 = getWhiteCode();
+           } while (code3 >= 64);
+         } else {
+-          code1 = code2 = 0;
+           do {
+-            code1 += code3 = getBlackCode();
++            code1 += code3 = getWhiteCode();
+           } while (code3 >= 64);
+           do {
+-            code2 += code3 = getWhiteCode();
++            code2 += code3 = getBlackCode();
+           } while (code3 >= 64);
+         }
+-        if (code1 > 0 || code2 > 0) {
+-          codingLine[a0 + 1] = a0New + code1;
+-          ++a0;
+-          a0New = codingLine[a0 + 1] = codingLine[a0] + code2;
+-          ++a0;
+-          while (refLine[b1] <= codingLine[a0] && refLine[b1] < columns)
+-            b1 += 2;
++        addPixels(codingLine[a0i] + code1, blackPixels);
++        if (codingLine[a0i] < columns) {
++          addPixels(codingLine[a0i] + code2, blackPixels ^ 1);
+         }
+-        break;
+-      case twoDimVert0:
+-        a0New = codingLine[++a0] = refLine[b1];
+-        if (refLine[b1] < columns) {
+-          ++b1;
+-          while (refLine[b1] <= codingLine[a0] && refLine[b1] < columns)
+-            b1 += 2;
++        while (refLine[b1i] <= codingLine[a0i] && refLine[b1i] < columns) {
++          b1i += 2;
+         }
+         break;
+-      case twoDimVertR1:
+-        a0New = codingLine[++a0] = refLine[b1] + 1;
+-        if (refLine[b1] < columns) {
+-          ++b1;
+-          while (refLine[b1] <= codingLine[a0] && refLine[b1] < columns)
+-            b1 += 2;
++      case twoDimVertR3:
++        addPixels(refLine[b1i] + 3, blackPixels);
++        blackPixels ^= 1;
++        if (codingLine[a0i] < columns) {
++          ++b1i;
++          while (refLine[b1i] <= codingLine[a0i] && refLine[b1i] < columns) {
++            b1i += 2;
++          }
+         }
+         break;
+-      case twoDimVertL1:
+-        if (a0 == 0 || refLine[b1] - 1 > a0New) {
+-        a0New = codingLine[++a0] = refLine[b1] - 1;
+-        --b1;
+-        while (refLine[b1] <= codingLine[a0] && refLine[b1] < columns)
+-          b1 += 2;
++      case twoDimVertR2:
++        addPixels(refLine[b1i] + 2, blackPixels);
++        blackPixels ^= 1;
++        if (codingLine[a0i] < columns) {
++          ++b1i;
++          while (refLine[b1i] <= codingLine[a0i] && refLine[b1i] < columns) {
++            b1i += 2;
++          }
+         }
+         break;
+-      case twoDimVertR2:
+-        a0New = codingLine[++a0] = refLine[b1] + 2;
+-        if (refLine[b1] < columns) {
+-          ++b1;
+-          while (refLine[b1] <= codingLine[a0] && refLine[b1] < columns)
+-            b1 += 2;
++      case twoDimVertR1:
++        addPixels(refLine[b1i] + 1, blackPixels);
++        blackPixels ^= 1;
++        if (codingLine[a0i] < columns) {
++          ++b1i;
++          while (refLine[b1i] <= codingLine[a0i] && refLine[b1i] < columns) {
++            b1i += 2;
++          }
++          }
++        break;
++      case twoDimVert0:
++        addPixels(refLine[b1i], blackPixels);
++        blackPixels ^= 1;
++        if (codingLine[a0i] < columns) {
++          ++b1i;
++          while (refLine[b1i] <= codingLine[a0i] && refLine[b1i] < columns) {
++            b1i += 2;
++          }
+         }
+         break;
+-      case twoDimVertL2:
+-        if (a0 == 0 || refLine[b1] - 2 > a0New) {
+-        a0New = codingLine[++a0] = refLine[b1] - 2;
+-        --b1;
+-        while (refLine[b1] <= codingLine[a0] && refLine[b1] < columns)
+-          b1 += 2;
++      case twoDimVertL3:
++        addPixelsNeg(refLine[b1i] - 3, blackPixels);
++        blackPixels ^= 1;
++        if (codingLine[a0i] < columns) {
++          if (b1i > 0) {
++            --b1i;
++          } else {
++            ++b1i;
++          }
++          while (refLine[b1i] <= codingLine[a0i] && refLine[b1i] < columns) {
++            b1i += 2;
++          }
+         }
+         break;
+-      case twoDimVertR3:
+-        a0New = codingLine[++a0] = refLine[b1] + 3;
+-        if (refLine[b1] < columns) {
+-          ++b1;
+-          while (refLine[b1] <= codingLine[a0] && refLine[b1] < columns)
+-            b1 += 2;
++      case twoDimVertL2:
++        addPixelsNeg(refLine[b1i] - 2, blackPixels);
++        blackPixels ^= 1;
++        if (codingLine[a0i] < columns) {
++          if (b1i > 0) {
++            --b1i;
++          } else {
++            ++b1i;
++          }
++          while (refLine[b1i] <= codingLine[a0i] && refLine[b1i] < columns) {
++            b1i += 2;
++          }
+         }
+         break;
+-      case twoDimVertL3:
+-        if (a0 == 0 || refLine[b1] - 3 > a0New) {
+-        a0New = codingLine[++a0] = refLine[b1] - 3;
+-        --b1;
+-        while (refLine[b1] <= codingLine[a0] && refLine[b1] < columns)
+-          b1 += 2;
++      case twoDimVertL1:
++        addPixelsNeg(refLine[b1i] - 1, blackPixels);
++        blackPixels ^= 1;
++        if (codingLine[a0i] < columns) {
++          if (b1i > 0) {
++            --b1i;
++          } else {
++            ++b1i;
++          }
++          while (refLine[b1i] <= codingLine[a0i] && refLine[b1i] < columns) {
++            b1i += 2;
++          }
+         }
+         break;
+       case EOF:
++        addPixels(columns, 0);
+         eof = gTrue;
+-        codingLine[a0 = 0] = columns;
+-        return EOF;
++        break;
+       default:
+         error(getPos(), "Bad 2D code %04x in CCITTFax stream", code1);
++        addPixels(columns, 0);
+         err = gTrue;
+         break;
+       }
+-      } while (codingLine[a0] < columns);
++      }
+ 
+     // 1-D encoding
+     } else {
+-      codingLine[a0 = 0] = 0;
+-      while (1) {
++      codingLine[0] = 0;
++      a0i = 0;
++      blackPixels = 0;
++      while (codingLine[a0i] < columns) {
+       code1 = 0;
+-      do {
+-        code1 += code3 = getWhiteCode();
+-      } while (code3 >= 64);
+-      codingLine[a0+1] = codingLine[a0] + code1;
+-      ++a0;
+-      if (codingLine[a0] >= columns)
+-        break;
+-      code2 = 0;
+-      do {
+-        code2 += code3 = getBlackCode();
+-      } while (code3 >= 64);
+-      codingLine[a0+1] = codingLine[a0] + code2;
+-      ++a0;
+-      if (codingLine[a0] >= columns)
+-        break;
+-      }
+-    }
+-
+-    if (codingLine[a0] != columns) {
+-      error(getPos(), "CCITTFax row is wrong length (%d)", codingLine[a0]);
+-      // force the row to be the correct length
+-      while (codingLine[a0] > columns) {
+-      --a0;
++      if (blackPixels) {
++        do {
++          code1 += code3 = getBlackCode();
++        } while (code3 >= 64);
++      } else {
++        do {
++          code1 += code3 = getWhiteCode();
++        } while (code3 >= 64);
++      }
++      addPixels(codingLine[a0i] + code1, blackPixels);
++      blackPixels ^= 1;
+       }
+-      codingLine[++a0] = columns;
+-      err = gTrue;
+     }
+ 
+     // byte-align the row
+@@ -1561,14 +1632,17 @@
+     // this if we know the stream contains end-of-line markers because
+     // the "just plow on" technique tends to work better otherwise
+     } else if (err && endOfLine) {
+-      do {
++      while (1) {
++      code1 = lookBits(13);
+       if (code1 == EOF) {
+         eof = gTrue;
+         return EOF;
+       }
++      if ((code1 >> 1) == 0x001) {
++        break;
++      }
+       eatBits(1);
+-      code1 = lookBits(13);
+-      } while ((code1 >> 1) != 0x001);
++      }
+       eatBits(12); 
+       if (encoding > 0) {
+       eatBits(1);
+@@ -1576,11 +1650,11 @@
+       }
+     }
+ 
+-    a0 = 0;
+-    outputBits = codingLine[1] - codingLine[0];
+-    if (outputBits == 0) {
+-      a0 = 1;
+-      outputBits = codingLine[2] - codingLine[1];
++    // set up for output
++    if (codingLine[0] > 0) {
++      outputBits = codingLine[a0i = 0];
++    } else {
++      outputBits = codingLine[a0i = 1];
+     }
+ 
+     ++row;
+@@ -1588,39 +1662,43 @@
+ 
+   // get a byte
+   if (outputBits >= 8) {
+-    ret = ((a0 & 1) == 0) ? 0xff : 0x00;
+-    if ((outputBits -= 8) == 0) {
+-      ++a0;
+-      if (codingLine[a0] < columns) {
+-      outputBits = codingLine[a0 + 1] - codingLine[a0];
+-      }
++    buf = (a0i & 1) ? 0x00 : 0xff;
++    outputBits -= 8;
++    if (outputBits == 0 && codingLine[a0i] < columns) {
++      ++a0i;
++      outputBits = codingLine[a0i] - codingLine[a0i - 1];
+     }
+   } else {
+     bits = 8;
+-    ret = 0;
++    buf = 0;
+     do {
+       if (outputBits > bits) {
+-      i = bits;
+-      bits = 0;
+-      if ((a0 & 1) == 0) {
+-        ret |= 0xff >> (8 - i);
++      buf <<= bits;
++      if (!(a0i & 1)) {
++        buf |= 0xff >> (8 - bits);
+       }
+-      outputBits -= i;
++      outputBits -= bits;
++      bits = 0;
+       } else {
+-      i = outputBits;
+-      bits -= outputBits;
+-      if ((a0 & 1) == 0) {
+-        ret |= (0xff >> (8 - i)) << bits;
++      buf <<= outputBits;
++      if (!(a0i & 1)) {
++        buf |= 0xff >> (8 - outputBits);
+       }
++      bits -= outputBits;
+       outputBits = 0;
+-      ++a0;
+-      if (codingLine[a0] < columns) {
+-        outputBits = codingLine[a0 + 1] - codingLine[a0];
++      if (codingLine[a0i] < columns) {
++        ++a0i;
++        outputBits = codingLine[a0i] - codingLine[a0i - 1];
++      } else if (bits > 0) {
++        buf <<= bits;
++        bits = 0;
+       }
+       }
+-    } while (bits > 0 && codingLine[a0] < columns);
++    } while (bits);
++  }
++  if (black) {
++    buf ^= 0xff;
+   }
+-  buf = black ? (ret ^ 0xff) : ret;
+   return buf;
+ }
+ 
+@@ -1662,6 +1740,9 @@
+   code = 0; // make gcc happy
+   if (endOfBlock) {
+     code = lookBits(12);
++    if (code == EOF) {
++      return 1;
++    }
+     if ((code >> 5) == 0) {
+       p = &whiteTab1[code];
+     } else {
+@@ -1674,6 +1755,9 @@
+   } else {
+     for (n = 1; n <= 9; ++n) {
+       code = lookBits(n);
++      if (code == EOF) {
++      return 1;
++      }
+       if (n < 9) {
+       code <<= 9 - n;
+       }
+@@ -1685,6 +1769,9 @@
+     }
+     for (n = 11; n <= 12; ++n) {
+       code = lookBits(n);
++      if (code == EOF) {
++      return 1;
++      }
+       if (n < 12) {
+       code <<= 12 - n;
+       }
+@@ -1710,9 +1797,12 @@
+   code = 0; // make gcc happy
+   if (endOfBlock) {
+     code = lookBits(13);
++    if (code == EOF) {
++      return 1;
++    }
+     if ((code >> 7) == 0) {
+       p = &blackTab1[code];
+-    } else if ((code >> 9) == 0) {
++    } else if ((code >> 9) == 0 && (code >> 7) != 0) {
+       p = &blackTab2[(code >> 1) - 64];
+     } else {
+       p = &blackTab3[code >> 7];
+@@ -1724,6 +1814,9 @@
+   } else {
+     for (n = 2; n <= 6; ++n) {
+       code = lookBits(n);
++      if (code == EOF) {
++      return 1;
++      }
+       if (n < 6) {
+       code <<= 6 - n;
+       }
+@@ -1735,6 +1828,9 @@
+     }
+     for (n = 7; n <= 12; ++n) {
+       code = lookBits(n);
++      if (code == EOF) {
++      return 1;
++      }
+       if (n < 12) {
+       code <<= 12 - n;
+       }
+@@ -1748,6 +1844,9 @@
+     }
+     for (n = 10; n <= 13; ++n) {
+       code = lookBits(n);
++      if (code == EOF) {
++      return 1;
++      }
+       if (n < 13) {
+       code <<= 13 - n;
+       }
+@@ -1972,6 +2071,12 @@
+     // allocate a buffer for the whole image
+     bufWidth = ((width + mcuWidth - 1) / mcuWidth) * mcuWidth;
+     bufHeight = ((height + mcuHeight - 1) / mcuHeight) * mcuHeight;
++    if (bufWidth <= 0 || bufHeight <= 0 ||
++       bufWidth > INT_MAX / bufWidth / (int)sizeof(int)) {
++      error(getPos(), "Invalid image size in DCT stream");
++      y = height;
++      return;
++    }
+     for (i = 0; i < numComps; ++i) {
+       frameBuf[i] = (int *)gmallocn(bufWidth * bufHeight, sizeof(int));
+       memset(frameBuf[i], 0, bufWidth * bufHeight * sizeof(int));
+@@ -3028,6 +3133,11 @@
+   }
+   scanInfo.firstCoeff = str->getChar();
+   scanInfo.lastCoeff = str->getChar();
++  if (scanInfo.firstCoeff < 0 || scanInfo.lastCoeff > 63 ||
++      scanInfo.firstCoeff > scanInfo.lastCoeff) {
++    error(getPos(), "Bad DCT coefficient numbers in scan info block");
++    return gFalse;
++  }
+   c = str->getChar();
+   scanInfo.ah = (c >> 4) & 0x0f;
+   scanInfo.al = c & 0x0f;
+diff -Naur poppler-0.5.4.orig/poppler/Stream.h poppler-0.5.4/poppler/Stream.h
+--- poppler-0.5.4.orig/poppler/Stream.h        2006-02-28 19:34:46.000000000 
+0000
++++ poppler-0.5.4/poppler/Stream.h     2008-03-28 20:07:21.000000000 +0000
+@@ -517,13 +517,15 @@
+   int row;                    // current row
+   int inputBuf;                       // input buffer
+   int inputBits;              // number of bits in input buffer
+-  short *refLine;             // reference line changing elements
+-  int b1;                     // index into refLine
+-  short *codingLine;          // coding line changing elements
+-  int a0;                     // index into codingLine
++  int *codingLine;             // coding line changing elements
++  int *refLine;                        // reference line changing elements
++  int a0i;                     // index into codingLine
++  GBool err;                   // error on current line
+   int outputBits;             // remaining ouput bits
+   int buf;                    // character buffer
+ 
++  void addPixels(int a1, int black);
++  void addPixelsNeg(int a1, int black);
+   short getTwoDimCode();
+   short getWhiteCode();
+   short getBlackCode();

-- 
http://linuxfromscratch.org/mailman/listinfo/patches
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to