On Mon, Feb 19, 2018 at 02:26:36PM +0000, Chris Clayton wrote:
> Thanks, Ken.
> 
> With this patch applied, ImageMagick-6.9.9-34 fails to build here. I get 
> messages about not knowing how to make
> pkgconfig .pc files. For example:
> 
>        No rule to make target 'magick/ImageMagick.pc', needed by 'all-am'
> 
> It's because the patch does not fully fix up the various instances of 
> Makefile.am.

Hi Chris,

Thanks for the report.  Are you sure that was the -2 patch ?

I'm not sure quite what happenned when I created the -1, a full
manual build seemed to work (but probably didn't get all the pc
files correct) so I put it in and gave it a go near the end of my
fresh 8.2 build.  At that point my scripted build failed because
some of the patch did not apply.

With my -2 version, I've just come back to that machine and I can't
find any messages like that in the log.  My log of what got
installed shows the following pkgconfig files:

/usr/lib/pkgconfig/ImageMagick++-6.Q16HDRI.pc
/usr/lib/pkgconfig/ImageMagick++-6.pc
/usr/lib/pkgconfig/ImageMagick-6.Q16HDRI.pc
/usr/lib/pkgconfig/ImageMagick-6.pc
/usr/lib/pkgconfig/Magick++-6.Q16HDRI.pc
/usr/lib/pkgconfig/Magick++-6.pc
/usr/lib/pkgconfig/MagickCore-6.Q16HDRI.pc
/usr/lib/pkgconfig/MagickCore-6.pc
/usr/lib/pkgconfig/MagickWand-6.Q16HDRI.pc
/usr/lib/pkgconfig/MagickWand-6.pc
/usr/lib/pkgconfig/Wand-6.Q16HDRI.pc
/usr/lib/pkgconfig/Wand-6.pc

> I've generated a new patch and
> successfully built 6.9.9-34 (and -35) with it. Because the various 
> Makefile.am files are changed by the new patch, I run
> "autoreconf -fi" after applying the patch and that causes configure to be 
> regenerated. Consequently, I haven't included
> any changes to configure in my patch.

Yeah, I've been here a long while - we used to prefer to not have to
rerun autofoo.  Thinking back, the first objective of getting the
original working patch was to ensure that everything got changed -
and that meant looking at those files, rather than what is used to
generate them.

BUT: you say there is a -35 release: that is bad news for me (I was
looking at IM git and seeing a lot of fixes for fuzzing), I had
begun to assume the process might be ongoing for a while.  Oh well,
after asking and not getting a reply, I suppose that putting
7.0.7-22 and 6.9.9-34 into the book has provoked the release.

I'll give your patch a go with -35.

For anybody playing along at home - the -22 and -34 versions have
now been removed from the main site, should probably be treated as
inadequate.

ĸen
-- 
Truth, in front of her huge walk-in wardrobe, selected black leather
boots with stiletto heels for such a barefaced truth.
                                     - Unseen Academicals
-- 
http://lists.linuxfromscratch.org/listinfo/patches
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to