Patches item #1177597, was opened at 2005-04-06 10:37 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1177597&group_id=5470
Category: Demos and tools Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: engelbert gruber (grubert) Assigned to: Nobody/Anonymous (nobody) Summary: Complex commented Initial Comment: i ran pychecker over Complex.py 1. "i is not defined": in the constructor, but __init__ looks strange to me, so i only made a comment and changed the second if to elif. 2. "sys" is not defined: in __hash__, moved import sys to the top. 3. "re" and "im" attributes dont exist: probably a pychecker problem, but i did add a comment. ---------------------------------------------------------------------- >Comment By: Martin v. L�wis (loewis) Date: 2005-04-09 12:53 Message: Logged In: YES user_id=21627 Thanks for the patch, committed as Complex.py 1.8, NEWS 1.1284 ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2005-04-08 20:29 Message: Logged In: YES user_id=80475 Sure, that is, if high standards of quality can be called greed ;-) ---------------------------------------------------------------------- Comment By: engelbert gruber (grubert) Date: 2005-04-08 17:39 Message: Logged In: YES user_id=147070 a liitle greedy arnt we :-) i tried harder, hope it will be more like it ---------------------------------------------------------------------- Comment By: Martin v. L�wis (loewis) Date: 2005-04-08 01:00 Message: Logged In: YES user_id=21627 Please review __init__ with the understanding that it is meant to compute re + im*1j even provided re or im could be complex. So "i" should probably be "im", and both re and im can be complex. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1177597&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
