Patches item #1166602, was opened at 2005-03-19 16:10 Message generated for change (Settings changed) made by facundobatista You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1166602&group_id=5470
Category: Library (Lib) Group: Python 2.4 >Status: Closed Resolution: None Priority: 5 Submitted By: Facundo Batista (facundobatista) Assigned to: Facundo Batista (facundobatista) Summary: Decimal interaction with __rop__ Initial Comment: Ok, this is the result of last discussion in python-dev. I changed _convert_other() to make it return NotImplemented, and check in every place where it's called to pass back the NotImplemented (something similar suggested Michael Hudson in the discussion: he passed back "other", but I think is cleaner just to pass the signal, and let the architecture to do whatever it should). The tests runs ok, seeing a +1.8% in test_decimal time. I'm sending this to you, because I... - Don't get to understand from the discussion if this is something that should be fixed at this level or at another. - Don't really know if this solution is as clean as it seems. Thanks! . Facundo ---------------------------------------------------------------------- >Comment By: Facundo Batista (facundobatista) Date: 2005-05-07 20:05 Message: Logged In: YES user_id=752496 Yours is slightly better, :). ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2005-04-10 13:44 Message: Logged In: YES user_id=80475 I had checked in my own patch for the rop issue. Please cross- check these two patches to see if one did something that the other had not. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1166602&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
