Patches item #1105730, was opened at 2005-01-20 06:34 Message generated for change (Comment added) made by birkenfeld You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1105730&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Library (Lib) Group: Python 2.4 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Jimmy Retzlaff (jretz) >Assigned to: Reinhold Birkenfeld (birkenfeld) Summary: Faster commonprefix in macpath, ntpath, etc. Initial Comment: Patch 681780 resulted in a faster version of commonprefix for posixpath.py. The same implementation should work fine for macpath.py, ntpath.py, os2emxpath.py, and plat-riscos/riscospath.py but it didn't make it into those. This is simply the posixpath.commonprefix implementation copied into these files. ---------------------------------------------------------------------- >Comment By: Reinhold Birkenfeld (birkenfeld) Date: 2005-08-03 09:31 Message: Logged In: YES user_id=1188172 Committed! Log follows: Checking in Misc/NEWS; new revision: 1.1329; previous revision: 1.1328 Checking in Lib/macpath.py; new revision: 1.51; previous revision: 1.50 Checking in Lib/ntpath.py; new revision: 1.62; previous revision: 1.61 Checking in Lib/os2emxpath.py; new revision: 1.14; previous revision: 1.13 Checking in Lib/plat-riscos/riscospath.py; new revision: 1.12; previous revision: 1.11 ---------------------------------------------------------------------- Comment By: Jimmy Retzlaff (jretz) Date: 2005-01-24 23:57 Message: Logged In: YES user_id=101588 I had assumed there were historical reasons that the platform specific implementations of os.path werent importing from each other. If this is not the case then Im all for eliminating the duplication of code. Im attaching an alternate patch (called importcommonprefix.diff) for this approach. I've tested it on Windows, but I don't have a means of testing the other versions. ---------------------------------------------------------------------- Comment By: Jeff Epler (jepler) Date: 2005-01-24 17:34 Message: Logged In: YES user_id=2772 Why not write 'from posixpath import commonprefix' in each of the other XXXpath.py modules, to benefit from any future improvements? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1105730&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
