Patches item #1094164, was opened at 2005-01-01 14:43
Message generated for change (Comment added) made by akuchling
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1094164&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: XML
Group: Python 2.4
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Felix Rabe (xitnalta)
>Assigned to: A.M. Kuchling (akuchling)
Summary: xml.dom.minidom.Node.replaceChild(obj, x, x) removes child x

Initial Comment:
A child was removed from a node if an attempt was made
to replace it with itself.  The cause was the
comparison "if newChild is oldChild:" happening too
late in the function's code, so I moved it before the
"newChild.parentNode" check.

----------------------------------------------------------------------

>Comment By: A.M. Kuchling (akuchling)
Date: 2005-11-22 14:05

Message:
Logged In: YES 
user_id=11375

Good catch; thanks!  Patch applied to HEAD and to
release24-maint.


----------------------------------------------------------------------

Comment By: Felix Rabe (xitnalta)
Date: 2005-01-01 14:45

Message:
Logged In: YES 
user_id=163986

The patch applies to CVS python/dist/src checked out half an
hour ago.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1094164&group_id=5470
_______________________________________________
Patches mailing list
[email protected]
http://mail.python.org/mailman/listinfo/patches

Reply via email to