Patches item #1436368, was opened at 2006-02-21 19:35 Message generated for change (Comment added) made by nnorwitz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1436368&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Core (C code) Group: Python 2.5 Status: Open Resolution: None Priority: 5 Submitted By: Travis Oliphant (teoliphant) Assigned to: Guido van Rossum (gvanrossum) Summary: PEP 357 --- adding nb_index Initial Comment: See PEP 357 for details. ---------------------------------------------------------------------- >Comment By: Neal Norwitz (nnorwitz) Date: 2006-02-21 23:33 Message: Logged In: YES user_id=33168 Travis, I briefly looked over the patches and have a few comments. It's easier if there's one big patch that contains all the code, tests, and doc. I noticed a second patch that contains the tests, but I didn't see any doc updates. I noticed some formatting which is not consistent with the style of the surrounding code (I think). Stuff like n=var->field (no spaces) and if (XXX) dosomething(); else return 5; Most places in the python code check for == NULL rather than the implicit check for 0. Most places in code don't do assignment in if (cond), though this last one is more variable. I'll try to look this over in more detail soon. But it probably won't be until PyCon. If you're there, maybe we can discuss in person. Also, if you have further PEP updates, feel free to send them to me and I can check them in. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1436368&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
