Patches item #1437769, was opened at 2006-02-24 00:18 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1437769&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Windows Group: Python 2.5 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Atul Varma (varmaa) Assigned to: Nobody/Anonymous (nobody) Summary: Size of time_t changed to 64 bits in MSVC++ 2005 CRT Initial Comment: As of Visual C++ 2005, the size of the time_t data type was changed from 32 bits to 64 bits. Among other things, this breaks the C API test in the Python "test" package, because Python thinks that time_t should be 32 bits large. Altering PC/pyconfig.h by conditionally defining SIZEOF_TIME_T depending on whether at least MSVC++ 2005 is being used for compilation fixes this. Attached is a very simple unified diff patch for PC/pyconfig.h, taken from revision 42382 (the most recent revision at the time of this submission). More information about this and other recent changes to the MS CRT for Visual C++ 2005 can be found here: http://msdn2.microsoft.com/en-us/library/ms235429.aspx ---------------------------------------------------------------------- >Comment By: Martin v. Löwis (loewis) Date: 2006-03-06 17:35 Message: Logged In: YES user_id=21627 Thanks for the patch. Committed in revision 42870. Looking at the "breaking changes" list, I see nothing else that would need attention. ---------------------------------------------------------------------- Comment By: Terry J. Reedy (tjreedy) Date: 2006-03-06 02:10 Message: Logged In: YES user_id=593130 The page specifically says "The default size for time_t is now 64 bits..." The page on breaking changes http://msdn2.microsoft.com/en-us/library/ms235497.aspx says "time_t is now a 64-bit value (unless _USE_32BIT_TIME_T is defined)." so it would appear that there is a possible alternative fix. My understanding of recent discussions is that the developers are not planning to upgrade their VC version at this time. Unless this is the only change needed, I would not be surprised if a more complete patch would be wanted at one time. Maybe someone else will say more. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1437769&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
