Patches item #1435422, was opened at 2006-02-20 15:17 Message generated for change (Comment added) made by catlee You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1435422&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Modules Group: Python 2.5 Status: Open Resolution: None Priority: 5 Submitted By: Chris AtLee (catlee) Assigned to: Nobody/Anonymous (nobody) Summary: Add copy() method to zlib's compress and decompress objects Initial Comment: The attached patch adds a copy() method to zlib's compressobj and decompressobj. Copying a (de)compression object allows a developer to store the state of the (de)compressor at a certain point of the input stream in order to more efficiently compress data sharing some identical header, or to more efficiently seek inside compressed data. Doc/lib/libzlib.tex is updated with descriptions for the new methods. Lib/test/test_zlib.py is updated to test the new functionality. The patch is against revision 42524 in http://svn.python.org/projects/python/trunk ---------------------------------------------------------------------- >Comment By: Chris AtLee (catlee) Date: 2006-03-27 16:46 Message: Logged In: YES user_id=186532 Patch for the unflush() docs is uploaded as #1459631 ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2006-03-27 13:56 Message: Logged In: YES user_id=33168 Yes, please fix any docs you find lacking. Also, please create a new patch. Thanks! ---------------------------------------------------------------------- Comment By: Chris AtLee (catlee) Date: 2006-03-27 13:52 Message: Logged In: YES user_id=186532 New patch attached with the mentioned changes made. I noticed that PyZlib_unflush() takes an argument, but that its use is not documented. Should the docs be updated to explain what that argument is for? ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2006-03-24 01:02 Message: Logged In: YES user_id=33168 You need to check the return result of newcompobject(). This would crash if it returns NULL. You also need to change METH_VARARGS to METH_NOARGS since these methods don't take any arguments. The doc should contain \versionadded{2.5} before the end markers for new methods. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1435422&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
