Patches item #1416559, was opened at 2006-01-27 16:50 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1416559&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Build Group: Python 2.4 Status: Closed Resolution: Accepted Priority: 5 Submitted By: Ronald Oussoren (ronaldoussoren) Assigned to: Nobody/Anonymous (nobody) Summary: Configure patch for Mac OS X 10.3 Initial Comment: This patch makes sure that _POSIX_SOURCE and friends won't get defined when you build on Panther. Defining those have no effect on Panther, but will make it impossible to build extensions on a Tiger system when Python itself was build on Panther. ---------------------------------------------------------------------- >Comment By: Martin v. Löwis (loewis) Date: 2006-04-04 08:09 Message: Logged In: YES user_id=21627 This patch cheated in a really dangerous way: the configure fragment was gained through editing, not through running autoconf. This was really bad, as it broke two months and a release later. The problem is that, in configure.in, [ does not denote a shell square bracket - it denotes an m4 quoted string. The square bracket is denoted with a quadrigraph. When committing configure.in, please always ignore configure fragments, and run autoconf/autoheader yourself. I fixed that in 43617 and 43618. ---------------------------------------------------------------------- Comment By: Georg Brandl (gbrandl) Date: 2006-04-01 10:51 Message: Logged In: YES user_id=849994 Committed in 43536, 43537. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2006-03-20 05:11 Message: Logged In: YES user_id=33168 Ronald, this looks fine, go ahead and checkin. ---------------------------------------------------------------------- Comment By: Ronald Oussoren (ronaldoussoren) Date: 2006-02-21 10:23 Message: Logged In: YES user_id=580910 I don't suppose this helps, but yes this patch is save. I use this in production and haven't found an extension yet that wouldn't work when this patch is applied. I've also looked at the platform header files to determine if the patch is save. We (Bob Ippolitto and myself) are using a simular patch in our ongoing work to create an universal build of python. ---------------------------------------------------------------------- Comment By: Georg Brandl (birkenfeld) Date: 2006-02-19 16:54 Message: Logged In: YES user_id=1188172 Can any OS X expert confirm that not defining _XOPEN_SOURCE and _POSIX_C_SOURCE hasn't a negative effect on OSX 10.3? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1416559&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
