Patches item #1162023, was opened at 2005-03-12 15:58 Message generated for change (Comment added) made by hoffmanm You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1162023&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Build Group: Python 2.5 Status: Closed Resolution: Out of Date Priority: 5 Submitted By: Michael Hoffman (hoffmanm) Assigned to: Neal Norwitz (nnorwitz) Summary: don't add -OPT:Olimit=0 for icc Initial Comment: Patch to configure.in to fix problem described in: http://sourceforge.net/tracker/?func=detail&aid=1162001&group_id=5470&atid=105470 ---------------------------------------------------------------------- >Comment By: Michael Hoffman (hoffmanm) Date: 2006-04-14 18:38 Message: Logged In: YES user_id=987664 I don't have svn installed yet, so it would be a lot of doing at the moment. That's on my list of things to do but don't have time right now and I doubt anyone else has time for this trivial thing. So I guess just forget it, sorry about the frustration. Closed related bug 1162001 as fixed. ---------------------------------------------------------------------- Comment By: Martin v. Löwis (loewis) Date: 2006-04-14 17:12 Message: Logged In: YES user_id=21627 Would you like to rework your patch so it applies to the current configure.in? I'll apply it then right away (although I still would like to see a patch that recognizes icc by feature, not by name) ---------------------------------------------------------------------- Comment By: Michael Hoffman (hoffmanm) Date: 2006-04-14 16:37 Message: Logged In: YES user_id=987664 It's disappointing that after all that the fix that was checked in eventually wasn't as complete as the patch I provided (i.e. does not deal with Martin's complaint of not catching e.g. CC=/usr/bin/icc). ---------------------------------------------------------------------- Comment By: Martin v. Löwis (loewis) Date: 2006-04-14 15:13 Message: Logged In: YES user_id=21627 Ok, something like this was committed as 41953; closing this patch as out-of-date. ---------------------------------------------------------------------- Comment By: Michael Hoffman (hoffmanm) Date: 2005-04-04 16:09 Message: Logged In: YES user_id=987664 Well, it probably can be done but that would really require a completely different patch. I unfortunately have not had the time to produce such a patch. ---------------------------------------------------------------------- Comment By: Martin v. Löwis (loewis) Date: 2005-03-18 18:27 Message: Logged In: YES user_id=21627 Hmm. I would really like to see something still more general, but am willing to commit this if you assert that nothing more general exists. Eg. what if somebody links /usr/bin/cc to icc? You really should find out whether the compiler *is* ICC, not whether its name is icc (or, better yet, whether the compiler really does support -OPT:Olimit). For example, if 'icc --version' prints "Intel Compiler version 9.0" or some such, that would be a reliable test for icc. ---------------------------------------------------------------------- Comment By: Michael Hoffman (hoffmanm) Date: 2005-03-18 13:17 Message: Logged In: YES user_id=987664 OK, here's another attempt at it that uses the autoconf AS_BASENAME macro. Additionally it removes libm from the default libraries if you are using icc. Intel has their own math library which is automatically linked, and using -lm causes problems. Sorry this took so long--anonymous CVS access had been down for several days. ---------------------------------------------------------------------- Comment By: Martin v. Löwis (loewis) Date: 2005-03-13 22:42 Message: Logged In: YES user_id=21627 This test is too weak. If CC is, say, "/opt/intel/bin/icc", the test would fail, right? So please come up with a separate test to determine if the compiler is icc, and then skip the entire test whether it accepts -OPT:Olimit. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1162023&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
