Patches item #1478993, was opened at 2006-04-29 09:43 Message generated for change (Comment added) made by bcannon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1478993&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Library (Lib) Group: Python 2.5 Status: Open Resolution: None Priority: 5 Submitted By: John J Lee (jjlee) Assigned to: Nobody/Anonymous (nobody) Summary: Take advantage of BaseException/Exception split in cookielib Initial Comment: The patch takes advantage of the exception hierarchy reorganisation to remove some ugly code in cookielib. It clarifies a couple of exception messages, too. ---------------------------------------------------------------------- >Comment By: Brett Cannon (bcannon) Date: 2006-04-29 14:12 Message: Logged In: YES user_id=357491 Overall the patch looks fine (on vacation so not up for applying and handling any possible failures so not going to assign to myself). But a question and a suggestion. Why were the error strings changed to use the repr instead of the string representation? What does it buy you? And if you are going to be changing the function name, you might want to consider using a leading underscore to prevent people from using it or getting exported. Otherwise I would define __all__ for the module. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1478993&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
