Patches item #1507676, was opened at 2006-06-17 08:38 Message generated for change (Comment added) made by arigo You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1507676&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Core (C code) Group: Python 2.5 Status: Open Resolution: None Priority: 5 Submitted By: Georg Brandl (gbrandl) Assigned to: Nobody/Anonymous (nobody) Summary: improve object.c and abstract.c exception messages Initial Comment: This patch adds the type of the offending object to many error messages in the abstract APIs, such as "iteration over non-sequence". ---------------------------------------------------------------------- >Comment By: Armin Rigo (arigo) Date: 2006-06-18 20:23 Message: Logged In: YES user_id=4771 Looks good. I think this should be checked in the trunk ASAP. ---------------------------------------------------------------------- Comment By: Georg Brandl (gbrandl) Date: 2006-06-17 11:20 Message: Logged In: YES user_id=849994 Thanks for your review! I incorporated the changes into the 2nd version. ---------------------------------------------------------------------- Comment By: Armin Rigo (arigo) Date: 2006-06-17 10:55 Message: Logged In: YES user_id=4771 One message is wrong, in typeobject.c:slot_tp_hash(). The object that is unhashable is not 'func', it is 'self'. In abstract.c, maybe the two error messages from PySequence_Size() and PyMapping_Size() should be different, as they depend on the presence of a different slot. I'd suggest, respectively, "len() of non-sequence object '%.200s'" and "len() of non-mapping object '%.200s'". The rest looks good and quite useful IMHO :-) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1507676&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
